Re: [PATCH v2] perf vendor events arm64: Fix for AmpereOne metrics

From: Namhyung Kim
Date: Tue Sep 26 2023 - 19:40:03 EST


On Wed, Sep 20, 2023 at 9:40 AM Ian Rogers <irogers@xxxxxxxxxx> wrote:
>
> On Tue, Sep 19, 2023 at 11:19 PM Ilkka Koskinen
> <ilkka@xxxxxxxxxxxxxxxxxxxxxx> wrote:
> >
> > This patch addresses review comments that were given for
> > 705ed549148f ("perf vendor events arm64: Add AmpereOne metrics")
> > but didn't make it to the original patch [1][2]
> >
> > Changes include: A fix for backend_memory formula, use of standard metrics
> > when possible, using #slots, renaming metrics to avoid spaces in the names,
> > and cleanup.
> >
> > [1] https://lore.kernel.org/linux-perf-users/e9bdacb-a231-36af-6a2e-6918ee7effa@xxxxxxxxxxxxxxxxxxxxxx/
> > [2] https://lore.kernel.org/linux-perf-users/20230826192352.3043220-1-ilkka@xxxxxxxxxxxxxxxxxxxxxx/
> >
> > Fixes: 705ed549148f ("perf vendor events arm64: Add AmpereOne metrics")
> > Signed-off-by: Ilkka Koskinen <ilkka@xxxxxxxxxxxxxxxxxxxxxx>
>
> Reviewed-by: Ian Rogers <irogers@xxxxxxxxxx>

Applied to perf-tools-next, thanks!