Re: [PATCH v1] dynamic_debug: add support for logs destination

From: jim . cromie
Date: Fri Sep 15 2023 - 14:03:21 EST


On Fri, Sep 15, 2023 at 9:49 AM Łukasz Bartosik <lb@xxxxxxxxxxxx> wrote:
>
> Add support for selection of dynamic debug logs destination.
> When enabled it allows to configure destination of each callsite
> individually. The option adds a framework (described by struct
> ddebug_dst_ops) which provides flexible means to add a new destination
> for debug logs. On top of the framework support for trace instance as
> destination is added. By default destination of debug logs is syslog.
> Syslog can be set explicitly by using dst keyword or is selected by
> default when dst keyword is omitted, for example:

A while back,
Cc: Vincent Whitchurch <vincent.whitchurch@xxxxxxxx>
proposed these patches:
https://lore.kernel.org/lkml/20200825153338.17061-1-vincent.whitchurch@xxxxxxxx/

his approach adds a single flag, +x or (my pref) +T
which sends the pr_debug to tracefs, independent of +p.
Steve Rostedt offered feedback on one of the versions,
and one could read that as provisional acceptance.

Ive worked his patchset since, it is here:
https://github.com/jimc/linux/tree/dd-trc-11
(it has some unrelated bits too)

but it sits atop another patchset:
https://lore.kernel.org/lkml/20230911230838.14461-1-jim.cromie@xxxxxxxxx/
or for git remote add
https://github.com/jimc/linux/tree/dd-fix-5i


syslog and/or tracefs seems sufficient, do you have a 3rd destination ?

thanks