Re: [PATCH -next] md: simplify md_seq_ops

From: Mariusz Tkaczyk
Date: Wed Sep 13 2023 - 06:32:38 EST


On Tue, 12 Sep 2023 09:02:19 +0800
Yu Kuai <yukuai1@xxxxxxxxxxxxxxx> wrote:

> >> +static void *md_seq_next(struct seq_file *seq, void *v, loff_t *pos)
> >> +{
> >> + return seq_list_next(v, &all_mddevs, pos);
> >> +}
> > Can it be so simple? Why previous versions takes care of holding "(void)*1"
> > and "(void)*2" then? Could you elaborate?
>
> "1" means printing "Personalities", which is now moved to md_seq_start,
> and "2" means printing "unsed devices" which is now moved to
> md_seq_stop. And now md_seq_next is only used to iterate the mddev list.
>

Ok, LGTM.

Mariusz