RE: [PATCH 2/2] dt-bindings: iio: hmc425a: add entry for HMC540S

From: Hennerich, Michael
Date: Tue Sep 12 2023 - 07:29:15 EST




> -----Original Message-----
> From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> Sent: Dienstag, 12. September 2023 11:17
> To: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Cc: Hennerich, Michael <Michael.Hennerich@xxxxxxxxxx>; Conor Dooley
> <conor@xxxxxxxxxx>; Cusco, Ana-Maria <Ana-Maria.Cusco@xxxxxxxxxx>;
> Lars-Peter Clausen <lars@xxxxxxxxxx>; Jonathan Cameron
> <jic23@xxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@xxxxxxxxxx>; Conor Dooley
> <conor+dt@xxxxxxxxxx>; linux-iio@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 2/2] dt-bindings: iio: hmc425a: add entry for HMC540S
>
> [External]
>
> On Tue, 12 Sep 2023 08:56:56 +0200
> Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
> > On 12/09/2023 08:36, Hennerich, Michael wrote:
> > >
> > >
> > >> -----Original Message-----
> > >> From: Conor Dooley <conor@xxxxxxxxxx>
> > >> Sent: Mittwoch, 16. August 2023 16:37
> > >> To: Cusco, Ana-Maria <Ana-Maria.Cusco@xxxxxxxxxx>
> > >> Cc: Lars-Peter Clausen <lars@xxxxxxxxxx>; Hennerich, Michael
> > >> <Michael.Hennerich@xxxxxxxxxx>; Jonathan Cameron
> > >> <jic23@xxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof
> > >> Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>; Conor Dooley
> > >> <conor+dt@xxxxxxxxxx>; linux-iio@xxxxxxxxxxxxxxx;
> > >> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> > >> Subject: Re: [PATCH 2/2] dt-bindings: iio: hmc425a: add entry for
> > >> HMC540S
> > >>
> > >> [External]
> > >>
> > >> On Wed, Aug 16, 2023 at 02:09:06PM +0300, Ana-Maria Cusco wrote:
> > >>> Added support for HMC540SLP3E broadband 4-bit Silicon IC digital
> > >>> attenuator with a 15 dB control range and wide frequency coverage
> > >>> (0.1 to 8 GHz).
> > >>>
> > >>> Signed-off-by: Ana-Maria Cusco <ana-maria.cusco@xxxxxxxxxx>
> > >>
> > >> Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> > >
> > > Adding missing Signed-off-by tag
> > >
> > > Signed-off-by: Michael Hennerich <michael.hennerich@xxxxxxxxxx>
> >
> > Why it is missing? What is the purpose of this adding?
> >
> > Best regards,
> > Krzysztof
> >
> >
>
> Wrong patch. This is supposed to be on patch 1 where Michael was the
> author (he confirmed intent in response to a linux-next missing sign-off mail).
> I've added it there, but if you can reply to that email Michael, it will make
> things nice and clear.
>
> Jonathan

Sorry - my fault.

The Signed-off-by tag should have been for patch "iio: amplifiers: hmc425a: Add Support HMC540S 4-bit Attenuator"

Regards,
Michael