Re: [PATCH v2] dt-bindings: arm64: dts: mediatek: add description for mt8365-evk board

[Macpaul Lin]

On 9/11/23 17:49, Krzysztof Kozlowski wrote:
> 	
>
> External email : Please do not click links or open attachments until you 
> have verified the sender or the content.
>
> On 11/09/2023 10:11, Macpaul Lin wrote:
> > Fix the missing description for MediaTek mt8365-evk board.
> >
> > Fixes: 4f5fc078ac6f ("dt-bindings: arm64: dts: mediatek: Add mt8365-evk board")
>
> This is a friendly reminder during the review process.
>
> It seems my previous comments were not fully addressed. Maybe my
> feedback got lost between the quotes, maybe you just forgot to apply it.
> Please go back to the previous discussion and either implement all
> requested changes or keep discussing them.
>
> Thank you.

In the previous modifications, I overlooked this suggestion. It will be 
corrected in the next version.

> > Signed-off-by: Macpaul Lin <macpaul.lin@xxxxxxxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/arm/mediatek.yaml | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > change for v2:
> >  - rebase this patch to follow the v5 patch set of mt8395.
> >   - depends on https://lore.kernel.org/lkml/20230909132819.21626-2-macpaul.lin@xxxxxxxxxxxx/T/
> >  - Fix description as a single board.
> >
> > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> > index 2e8ad49c3479..b163995e32d5 100644
> > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> > @@ -244,7 +244,8 @@ properties:
> >            - enum:
> >                - mediatek,mt8183-pumpkin
> >            - const: mediatek,mt8183
> > -      - items:
> > +      - description: MediaTek Genio 350 Board (Genio 350 EVK)
>
> Drop, no need, redundant (copies the compatible) and your other entries
> do not have it.

The primary objective of this patch is to incorporate a description that 
will prevent users from confusing this platform with others. 
Additionally, it aids in identifying this as a "Genio EVK" for marketing 
purposes.

> > +        items:
> >            - enum:
>
> This is still confusing. Why do you have enum here with such description.

In order to accommodate the current market situation for a single 
reference board, will replace this with a 'const'.

> Best regards,
> Krzysztof

Thanks
Macpaul Lin