Re: [PATCH v3 4/5] usb: typec: tcpci_rt1711h: Add enable_pd30_extended_message variable to struct rt1711h_chip_info

[Heikki Krogerus]

On Wed, Sep 06, 2023 at 09:06:18AM +0100, Biju Das wrote:
> The RT1715 has PD30 extended message compared to RT1711H. Add a variable
> enable_pd30_extended_message to struct rt1711h_chip_info to enable this
> feature for RT1715.
> 
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>

> ---
> v2->v3:
>  * Added Rb tag from Andy.
> v1->v2:
>  * Changed enable_pd30_extended_message variable type to bool.
> ---
>  drivers/usb/typec/tcpm/tcpci_rt1711h.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/typec/tcpm/tcpci_rt1711h.c b/drivers/usb/typec/tcpm/tcpci_rt1711h.c
> index 40822bae9ae8..5d2dc7ead9d0 100644
> --- a/drivers/usb/typec/tcpm/tcpci_rt1711h.c
> +++ b/drivers/usb/typec/tcpm/tcpci_rt1711h.c
> @@ -54,6 +54,7 @@
>  struct rt1711h_chip_info {
>  	u32 rxdz_sel;
>  	u16 did;
> +	bool enable_pd30_extended_message;
>  };
>  
>  struct rt1711h_chip {
> @@ -110,7 +111,7 @@ static int rt1711h_init(struct tcpci *tcpci, struct tcpci_data *tdata)
>  		return ret;
>  
>  	/* Enable PD30 extended message for RT1715 */
> -	if (chip->info->did == RT1715_DID) {
> +	if (chip->info->enable_pd30_extended_message) {
>  		ret = regmap_update_bits(regmap, RT1711H_RTCTRL8,
>  					 RT1711H_ENEXTMSG, RT1711H_ENEXTMSG);
>  		if (ret < 0)
> @@ -400,6 +401,7 @@ static const struct rt1711h_chip_info rt1711h = {
>  static const struct rt1711h_chip_info rt1715 = {
>  	.rxdz_sel = RT1711H_BMCIO_RXDZSEL,
>  	.did = RT1715_DID,
> +	.enable_pd30_extended_message = true,
>  };
>  
>  static const struct i2c_device_id rt1711h_id[] = {
> -- 
> 2.25.1

-- 
heikki