Re: [PATCH v4 07/17] media: qcom: camss: Pass CAMSS subdev callbacks via resource ops pointer

[Konrad Dybcio]

On 7.09.2023 18:44, Bryan O'Donoghue wrote:
> It is possible to pass all of the CAMSS subdevice internal operations
> pointers from the controlling resources structure with an additional
> pointer added to the resources structure.
> 
> This allows for the removal of most of the probe-time control structures.
> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> ---
[...]

> diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
> index 54886a2a449b0..12131d9ea7ca8 100644
> --- a/drivers/media/platform/qcom/camss/camss.c
> +++ b/drivers/media/platform/qcom/camss/camss.c
> @@ -42,7 +42,8 @@ static const struct camss_subdev_resources csiphy_res_8x16[] = {
>  				{ 0 },
>  				{ 100000000, 200000000 } },
>  		.reg = { "csiphy0", "csiphy0_clk_mux" },
> -		.interrupt = { "csiphy0" }
> +		.interrupt = { "csiphy0" },
> +		.ops = &csiphy_ops_2ph_1_0
I'd really vouch for adding commas at the end, so that the
next diffs will be smaller

otherwise

Acked-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

Konrad