Re: [PATCH] firmware: ti_sci: Mark driver as non removable

[Uwe Kleine-König]

Hello,

On Thu, Sep 07, 2023 at 10:47:00PM +0530, Dhruva Gole wrote:
> The TI-SCI message protocol provides a way to communicate between
> various compute processors with a central system controller entity. It
> provides the fundamental device management capability and clock control
> in the SOCs that it's used in.
> 

Maybe add:

	The remove function failed to do all the necessary cleanup if
	there are registered users. Some things are freed however which
	likely results in an oops later on.

> Ensure that the driver isn't unbound by suppressing its bind and unbind
> sysfs attributes. As the driver is built-in there is no way to remove
> device once bound.
> 
> We can also remove the ti_sci_remove call along with the
> ti_sci_debugfs_destroy as there are no callers for it any longer.
> 
> Fixes: aa276781a64a ("firmware: Add basic support for TI System Control Interface (TI-SCI) protocol")
> Suggested-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> Signed-off-by: Dhruva Gole <d-gole@xxxxxx>

While this isn't the most elegant solution, this is probably the most
feasible one.

Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

(with or without the suggested addition to the commit log above).

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature