Re: [PATCH 5/7] fbdev/core: Build fb_logo iff CONFIG_LOGO has been selected
From: Thomas Zimmermann
Date: Thu Sep 07 2023 - 13:35:28 EST
Am 06.09.23 um 12:12 schrieb Javier Martinez Canillas:
Thomas Zimmermann <tzimmermann@xxxxxxx> writes:
Only build fb_logo.c if CONFIG_LOGO has been selected. Otherwise
provide empty implementations of the contained interfaces and avoid
using the exported variables.
Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
Ah! You are doing in this patch exactly what I mentioned in my previous
email :)
I would just squash this patch with #4, but up to you.
I'll refactor these patches slightly: The unexporting of the helpers
goes into a new patch and the rest of patches 4 and 5 will be squashed.
Acked-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature