Re: [PATCH net v2 2/2] iavf: schedule a request immediately after add/delete vlan

From: Simon Horman
Date: Thu Sep 07 2023 - 12:13:40 EST


On Thu, Sep 07, 2023 at 05:02:51PM +0200, Petr Oros wrote:
> When the iavf driver wants to reconfigure the VLAN filters
> (iavf_add_vlan, iavf_del_vlan), it sets a flag in
> aq_required:
> adapter->aq_required |= IAVF_FLAG_AQ_ADD_VLAN_FILTER;
> or:
> adapter->aq_required |= IAVF_FLAG_AQ_DEL_VLAN_FILTER;
>
> This is later processed by the watchdog_task, but it runs periodically
> every 2 seconds, so it can be a long time before it processes the request.
>
> In the worst case, the interface is unable to receive traffic for more
> than 2 seconds for no objective reason.
>
> Signed-off-by: Petr Oros <poros@xxxxxxxxxx>
> Co-developed-by: Michal Schmidt <mschmidt@xxxxxxxxxx>
> Signed-off-by: Michal Schmidt <mschmidt@xxxxxxxxxx>
> Co-developed-by: Ivan Vecera <ivecera@xxxxxxxxxx>
> Signed-off-by: Ivan Vecera <ivecera@xxxxxxxxxx>
> Reviewed-by: Ahmed Zaki <ahmed.zaki@xxxxxxxxx>

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>