Re: [PATCH 1/3] dt-bindings: Add ROHM BM1390 pressure sensor

[Conor Dooley]

On Wed, Sep 06, 2023 at 03:37:19PM +0300, Matti Vaittinen wrote:
> BM1390GLV-Z is a pressure sensor which performs internal temperature
> compensation for the MEMS. Pressure range is from 300 hPa to 1300 hPa
> and sample averaging and IIR filtering is built in sensor. Temperature
> measurement is also supported.
> 
> Add dt-bindings for the sensor.
> 
> Signed-off-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx>
> ---
>  .../bindings/iio/pressure/rohm,bm1390.yaml    | 52 +++++++++++++++++++
>  1 file changed, 52 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/pressure/rohm,bm1390.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/pressure/rohm,bm1390.yaml b/Documentation/devicetree/bindings/iio/pressure/rohm,bm1390.yaml
> new file mode 100644
> index 000000000000..d681fdd0f5ea
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/pressure/rohm,bm1390.yaml
> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/pressure/rohm,bm1390.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ROHM BM1390 pressure sensor
> +
> +maintainers:
> +  - Matti Vaittinen <mazziesaccount@xxxxxxxxx>
> +
> +description: |

You've got no formatting to preserve the | is not needed.

> +  BM1390GLV-Z is a pressure sensor which performs internal temperature
> +  compensation for the MEMS. Pressure range is from 300 hPa to 1300 hPa
> +  and sample averaging and IIR filtering is built in sensor.

nit: "built in to the sensor." or just "built-in."

Otherwise this seems alright to me,
Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

> Temperature
> +  measurement is also supported.
> +
> +properties:
> +  compatible:
> +    const: rohm,bm1390glv-z
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  vdd-supply: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - vdd-supply
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        pressure-sensor@5d {
> +            compatible = "kionix,kx022a";
> +            reg = <0x5d>;
> +
> +            interrupt-parent = <&gpio1>;
> +            interrupts = <29 IRQ_TYPE_LEVEL_LOW>;
> +
> +            vdd-supply = <&vdd>;
> +        };
> +    };
> -- 
> 2.41.0
> 
> 
> -- 
> Matti Vaittinen, Linux device drivers
> ROHM Semiconductors, Finland SWDC
> Kiviharjunlenkki 1E
> 90220 OULU
> FINLAND
> 
> ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
> Simon says - in Latin please.
> ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
> Thanks to Simon Glass for the translation =]

Attachment: signature.asc
Description: PGP signature