Re: [PATCH bpf-next v2 5/8] arm32, bpf: add support for 32-bit signed division

From: Russell King (Oracle)
Date: Thu Sep 07 2023 - 12:08:47 EST


On Wed, Sep 06, 2023 at 06:33:17PM +0000, Puranjay Mohan wrote:
> The cpuv4 added a new BPF_SDIV instruction that does signed division.
> The encoding is similar to BPF_DIV but BPF_SDIV sets offset=1.
>
> ARM32 already supports 32-bit BPF_DIV which can be easily extended to
> support BPF_SDIV as ARM32 has the SDIV instruction. When the CPU is not
> ARM-v7, we implement that SDIV/SMOD with the function call similar to
> the implementation of DIV/MOD.
>
> Signed-off-by: Puranjay Mohan <puranjay12@xxxxxxxxx>

Reviewed-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx>

Thanks, this is a lot more clear!

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!