Re: [PATCH v2,2/3] drm/mediatek: Add mt8188 dsi compatible to mtk_dsi.c

[CK Hu (胡俊光)]

Hi, Shuijing:

On Thu, 2023-09-07 at 14:08 +0800, CK Hu wrote:
> Hi, Shuijing:
> 
> On Fri, 2023-06-16 at 15:36 +0800, Shuijing Li wrote:
> > Add the compatible because there are different definitions for cmdq
> > register bit control in mt8188.
> > 
> > Signed-off-by: Shuijing Li <shuijing.li@xxxxxxxxxxxx>
> > Signed-off-by: Jitao Shi <jitao.shi@xxxxxxxxxxxx>
> > Reviewed-by: Matthias Brugger <matthias.bgg@xxxxxxxxx>
> > ---
> >  drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 ++
> >  drivers/gpu/drm/mediatek/mtk_dsi.c     | 8 ++++++++
> >  2 files changed, 10 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> > b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> > index 6dcb4ba2466c..0070894d0148 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> > @@ -764,6 +764,8 @@ static const struct of_device_id
> > mtk_ddp_comp_dt_ids[] = {
> >  	  .data = (void *)MTK_DSI },
> >  	{ .compatible = "mediatek,mt8186-dsi",
> >  	  .data = (void *)MTK_DSI },
> > +	{ .compatible = "mediatek,mt8188-dsi",
> > +	  .data = (void *)MTK_DSI },
> >  	{ }
> >  };
> >  
> > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c
> > b/drivers/gpu/drm/mediatek/mtk_dsi.c
> > index 7d5250351193..500a3054282d 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> > @@ -1208,6 +1208,12 @@ static const struct mtk_dsi_driver_data
> > mt8186_dsi_driver_data = {
> >  	.has_size_ctl = true,
> >  };
> >  
> > +static const struct mtk_dsi_driver_data mt8188_dsi_driver_data = {
> > +	.reg_cmdq_off = 0xd00,
> > +	.has_shadow_ctl = true,
> > +	.has_size_ctl = true,
> > +};
> > +
> >  static const struct of_device_id mtk_dsi_of_match[] = {
> >  	{ .compatible = "mediatek,mt2701-dsi",
> >  	  .data = &mt2701_dsi_driver_data },
> > @@ -1217,6 +1223,8 @@ static const struct of_device_id
> > mtk_dsi_of_match[] = {
> >  	  .data = &mt8183_dsi_driver_data },
> >  	{ .compatible = "mediatek,mt8186-dsi",
> >  	  .data = &mt8186_dsi_driver_data },
> > +	{ .compatible = "mediatek,mt8188-dsi",
> > +	  .data = &mt8188_dsi_driver_data },
> 
> mt8188_dsi_driver_data is identical to mt8186_dsi_driver_data, so use
> mt8186_dsi_driver_data and drop mt8188_dsi_driver_data.

Sorry that next patch would make mt8188_dsi_driver_data different than
mt8186_dsi_driver_data. So reorder this patch to be after the next
patch.

Regards,
CK

> 
> Regards,
> CK
> 
> >  	{ },
> >  };
> >  MODULE_DEVICE_TABLE(of, mtk_dsi_of_match);