Re: [PATCH v4 2/3] greybus: Add BeaglePlay Linux Driver

From: kernel test robot
Date: Wed Sep 06 2023 - 17:06:11 EST


Hi Ayush,

kernel test robot noticed the following build errors:

[auto build test ERROR on tty/tty-testing]
[also build test ERROR on tty/tty-next tty/tty-linus linus/master v6.5 next-20230906]
[cannot apply to robh/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Ayush-Singh/dt-bindings-Add-beaglecc1352/20230903-022958
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
patch link: https://lore.kernel.org/r/20230902182845.1840620-3-ayushdevel1325%40gmail.com
patch subject: [PATCH v4 2/3] greybus: Add BeaglePlay Linux Driver
config: microblaze-randconfig-r022-20230907 (https://download.01.org/0day-ci/archive/20230907/202309070423.35kLcJgy-lkp@xxxxxxxxx/config)
compiler: microblaze-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230907/202309070423.35kLcJgy-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309070423.35kLcJgy-lkp@xxxxxxxxx/

All error/warnings (new ones prefixed by >>):

>> drivers/greybus/gb-beagleplay.c:490:1: warning: data definition has no type or storage class
490 | module_serdev_device_driver(gb_beagleplay_driver);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/greybus/gb-beagleplay.c:490:1: error: type defaults to 'int' in declaration of 'module_serdev_device_driver' [-Werror=implicit-int]
>> drivers/greybus/gb-beagleplay.c:490:1: warning: parameter names (without types) in function declaration
>> drivers/greybus/gb-beagleplay.c:481:36: warning: 'gb_beagleplay_driver' defined but not used [-Wunused-variable]
481 | static struct serdev_device_driver gb_beagleplay_driver = {
| ^~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors


vim +490 drivers/greybus/gb-beagleplay.c

480
> 481 static struct serdev_device_driver gb_beagleplay_driver = {
482 .probe = gb_beagleplay_probe,
483 .remove = gb_beagleplay_remove,
484 .driver = {
485 .name = "gb_beagleplay",
486 .of_match_table = of_match_ptr(gb_beagleplay_of_match),
487 },
488 };
489
> 490 module_serdev_device_driver(gb_beagleplay_driver);
491

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki