Re: [PATCH 1/6] arm64: dts: qcom: sm8550-mtp: use correct UFS supply

From: Krzysztof Kozlowski
Date: Wed Sep 06 2023 - 08:06:06 EST


On 06/09/2023 13:50, Konrad Dybcio wrote:
> On 6.09.2023 13:39, Krzysztof Kozlowski wrote:
>> On 06/09/2023 13:28, Konrad Dybcio wrote:
>>> On 6.09.2023 12:47, Krzysztof Kozlowski wrote:
>>>> According to schematics the VCCQ2 supply is not connected and the L3G
>>>> regulator instead powers up the controller pads (VDD_PX10). Use correct
>>>> supply vdd-hba and drop unsupported current limit for the vdd-hba.
>>> Why is it unsupported?
>>
>> Maybe I was here not precise. I move the regulator from vccq2 to
>> vdd-hba. vccq2 has control of current in UFS core driver. Bindings also
>> allow it.
> Looks like the bindings are out of sync with the driver.
>
> ufshcd_populate_vreg() which parses current is used for both vccq2
> and vdd-hba.

Just for convenience. The current is not used for vdd-hba. Also:

https://lore.kernel.org/all/20230906113302.201888-1-krzysztof.kozlowski@xxxxxxxxxx/

Best regards,
Krzysztof