Re: [PATCH 1/5] arm64: dts: qcom: qrb2210-rb1: Swap UART index

[Dmitry Baryshkov]

On 06/09/2023 14:05, Dmitry Baryshkov wrote:
> On 06/09/2023 12:24, Konrad Dybcio wrote:
> > Newer RB1 board revisions have a debug UART on QUP0. Sadly, it looks
>
> Nit: I think this is '.. revisions should have...'. Because I was told 
> that the board I got is the final design / production.
>
> > like even when ordering one in retail, customers receive prototype
> > boards with "Enginering Sample" written on them.
> >
> > Use QUP4 for UART to make all known RB1 boards boot.
> >
> > Fixes: e18771961336 ("arm64: dts: qcom: Add initial QTI RB1 device tree")
> > Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
>
> Reported-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>

Ugh. This should have been:

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>


> > ---
> >   arch/arm64/boot/dts/qcom/qrb2210-rb1.dts | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts 
> > b/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts
> > index eadba066972e..5cda5b761455 100644
> > --- a/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts
> > +++ b/arch/arm64/boot/dts/qcom/qrb2210-rb1.dts
> > @@ -13,7 +13,7 @@ / {
> >       compatible = "qcom,qrb2210-rb1", "qcom,qrb2210", "qcom,qcm2290";
> >       aliases {
> > -        serial0 = &uart0;
> > +        serial0 = &uart4;
> >           sdhc1 = &sdhc_1;
> >           sdhc2 = &sdhc_2;
> >       };
> > @@ -357,7 +357,7 @@ key_volp_n: key-volp-n-state {
> >   };
> >   /* UART connected to the Micro-USB port via a FTDI chip */
> > -&uart0 {
> > +&uart4 {
> >       compatible = "qcom,geni-debug-uart";
> >       status = "okay";
> >   };

--
With best wishes
Dmitry