Re: [PATCH 3/7] fbdev/core: Fix style of code for boot-up logo
From: Javier Martinez Canillas
Date: Wed Sep 06 2023 - 06:02:25 EST
Thomas Zimmermann <tzimmermann@xxxxxxx> writes:
> Fix a number of warnings from checkpatch.pl in this code before
> moving it into a separate file. This includes
>
> * Prefer 'unsigned int' to bare use of 'unsigned'
> * space required after that ',' (ctx:VxV)
> * space prohibited after that open parenthesis '('
> * suspect code indent for conditional statements (16, 32)
> * braces {} are not necessary for single statement blocks
>
> No functional changes.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
> ---
[...]
> - static const unsigned char mask[] = { 0,0x80,0xc0,0xe0,0xf0,0xf8,0xfc,0xfe,0xff };
> + static const unsigned char mask[] = {
> + 0, 0x80, 0xc0, 0xe0, 0xf0, 0xf8, 0xfc, 0xfe, 0xff
> + };
I didn't know that checkpatch.pl complained about this.
Acked-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat