Re: [PATCH v10 net-next 08/23] net/tcp: Add AO sign to RST packets

[Dmitry Safonov]

Hi Simon,

Sorry for the delayed answer, I went on a vacation.

On 8/16/23 12:50, Simon Horman wrote:
> On Tue, Aug 15, 2023 at 08:14:37PM +0100, Dmitry Safonov wrote:
[..]
>> +	if (tcp_ao_prepare_reset(sk, skb, aoh, l3index, reply->seq,
>> +				 &key, &traffic_key, &allocated_traffic_key,
>> +				 &keyid, &ao_sne))
> 
> Hi Dmitry,
> 
> The type of the 4th parameter of tcp_ao_prepare_reset() (seq) is u32,
> but here a __be32 value is passed.

Yeah, it gets converted in patch "net/tcp: Add TCP-AO sign to twsk".

> Also, it seems that parameter is unused by tcp_ao_prepare_reset().

And only gets used in "net/tcp: Add TCP-AO SNE support".

Hard times when you keep changing the patch set, eventually some nits
and bits get introduced in earlier patches only to be modified by later.

What's worse, I can see that seq is getting used as ntohl(seq) and
tcp_v6_send_reset() does htonl(seq). So, it's better be u32 argument,
introduced by SNE patch, rather than gets converted to-and-back.

Thanks for noticing!

[..]

-- 
           Dmitry