Re: [PATCH v2 3/4] arm64: dts: qcom: sc7180: Add tertiary mi2s pinctrl

From: Nikita Travkin
Date: Tue Sep 05 2023 - 13:34:09 EST


Konrad Dybcio писал(а) 05.09.2023 20:53:
> On 5.09.2023 12:41, Nikita Travkin wrote:
>> Some devices use tertiary mi2s to connect external audio codec.
>> Add it near the other two i2s pinctrl definitions so the devices don't
>> have to duplicate it.
>>
>> Signed-off-by: Nikita Travkin <nikita@xxxxxxx>
>> ---
> This sorting makes no sense, neither alphabetically nor gpio-idx-wise
>
> I'd suggest chucking it in after pri_mi2s_mclk_active.
>

I assumed these are alphabetically sorted since other nodes before mostly
are, with the pri_* being an outlier, but I can move it below if you think
it would be better.

Nikita

> Konrad