Re: [PATCH 5/5] phy: qcom-qmp-usb: Add Qualcomm SDX75 USB3 PHY support

[Rohit Agarwal]

On 9/5/2023 12:23 PM, Krzysztof Kozlowski wrote:
> On 05/09/2023 06:43, Rohit Agarwal wrote:
> > Add support for USB3 QMP PHY found in SDX75 platform.
> >
> > Signed-off-by: Rohit Agarwal <quic_rohiagar@xxxxxxxxxxx>
> > ---
>
>
> >   
> > +static const struct qmp_phy_cfg sdx75_usb3_uniphy_cfg = {
> > +	.lanes			= 1,
> > +	.offsets		= &qmp_usb_offsets_v5,
> > +
> > +	.serdes_tbl		= sdx75_usb3_uniphy_serdes_tbl,
> > +	.serdes_tbl_num		= ARRAY_SIZE(sdx75_usb3_uniphy_serdes_tbl),
> > +	.tx_tbl			= sdx75_usb3_uniphy_tx_tbl,
> > +	.tx_tbl_num		= ARRAY_SIZE(sdx75_usb3_uniphy_tx_tbl),
> > +	.rx_tbl			= sdx75_usb3_uniphy_rx_tbl,
> > +	.rx_tbl_num		= ARRAY_SIZE(sdx75_usb3_uniphy_rx_tbl),
> > +	.pcs_tbl		= sdx75_usb3_uniphy_pcs_tbl,
> > +	.pcs_tbl_num		= ARRAY_SIZE(sdx75_usb3_uniphy_pcs_tbl),
> > +	.pcs_usb_tbl		= sdx75_usb3_uniphy_pcs_usb_tbl,
> > +	.pcs_usb_tbl_num	= ARRAY_SIZE(sdx75_usb3_uniphy_pcs_usb_tbl),
> > +	.clk_list		= qmp_v4_sdx55_usbphy_clk_l,
> > +	.num_clks		= ARRAY_SIZE(qmp_v4_sdx55_usbphy_clk_l),
> > +	.reset_list		= msm8996_usb3phy_reset_l,
> > +	.num_resets		= ARRAY_SIZE(msm8996_usb3phy_reset_l),
> > +	.vreg_list		= qmp_phy_vreg_l,
> > +	.num_vregs		= ARRAY_SIZE(qmp_phy_vreg_l),
> > +	.regs			= qmp_v5_usb3phy_regs_layout,
> > +	.pcs_usb_offset		= 0x1000,
> > +
> > +	.has_pwrdn_delay	= true,
> > +
> Stray blank line
>
> > +};
> > +
> >   static const struct qmp_phy_cfg sm8350_usb3phy_cfg = {
> >   	.lanes			= 2,
> >   
> > @@ -1985,6 +2141,7 @@ static int qmp_usb_init(struct phy *phy)
> >   	void __iomem *dp_com = qmp->dp_com;
> >   	int ret;
> >   
> > +
> No need for this.
This got added because I was trying to debug earlier. Sorry for this.
But this should get caught by checkpatch, shouldnt it? I did run 
checkpatch script.

Thanks,
Rohit.
> Best regards,
> Krzysztof