Re: [RESEND PATCH] Revert "fuse: Apply flags2 only when userspace set the FUSE_INIT_EXT"

[Bernd Schubert]

On 9/4/23 16:21, André Draszik wrote:
> On Mon, 2023-09-04 at 15:41 +0200, Miklos Szeredi wrote:
> > On Mon, 4 Sept 2023 at 15:34, André Draszik <git@xxxxxxxxxx> wrote:
> > > From: André Draszik <andre.draszik@xxxxxxxxxx>
> > >
> > > This reverts commit 3066ff93476c35679cb07a97cce37d9bb07632ff.
> > >
> > > This patch breaks all existing userspace by requiring updates as
> > > mentioned in the commit message, which is not allowed.
> >
> > It might break something, but you need to tell us what that is, please.
>
> In my case, it's Android.
>
> More generally this breaks all user-spaces that haven't been updated. Not
> breaking user-space is one of the top rules the kernel has, if not the topmost.


Hmm, I guess Android is using one of the extended flags in the mean time.
Do you have more data what exactly fails? I had posted this patch last year,
when it was still rather early introduction of FUSE_INIT_EXT, hoping there was
nothing in production yet using these flags. But virtiofsd was already using it,
so the patch got delayed (I had actually assumed it would just get dropped).


Sorry for the trouble!


Bernd