Re: [PATCH] comedi: Fix driver module dependencies since HAS_IOPORT changes

[Ian Abbott]

On 01/09/2023 20:26, Ian Abbott wrote:
> Commit b5c75b68b7de ("comedi: add HAS_IOPORT dependencies") changed the
> "select" directives to "depend on" directives for several config
> stanzas, but the options they depended on could not be selected,
> breaking previously selected options.  Change them back to "select"
> directives and add "depends on HAS_IOPORT" to config entries for modules
> that either use inb()/outb() and friends directly, or (recursively)
> depend on modules that do so.
>
> Fixes: b5c75b68b7de ("comedi: add HAS_IOPORT dependencies")
> Cc: Niklas Schnelle <schnelle@xxxxxxxxxxxxx>
> Cc: Arnd Bergmann <arnd@xxxxxxxxxx>
> Cc: <stable@xxxxxxxxxxxxxxx> # v6.5+
> Signed-off-by: Ian Abbott <abbotti@xxxxxxxxx>
> ---
>   drivers/comedi/Kconfig | 119 +++++++++++++++++++++++++----------------
>   1 file changed, 72 insertions(+), 47 deletions(-)

Please ignore this patch.

I'll send another patch to revert b5c75b68b7de as recommended in the 
other replies on this thread by Arnd and Niklas.

--
-=( Ian Abbott <abbotti@xxxxxxxxx> || MEV Ltd. is a company  )=-
-=( registered in England & Wales.  Regd. number: 02862268.  )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-