RE: [PATCH 1/2] platform/mellanox: NVSW_SN2201 should depend on ACPI

[Vadim Pasternak]

> -----Original Message-----
> From: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Sent: Monday, 4 September 2023 15:01
> To: Andi Shyti <andi.shyti@xxxxxxxxxx>; Hans de Goede <hdegoede@xxxxxxxxxx>;
> Mark Gross <markgross@xxxxxxxxxx>; Vadim Pasternak <vadimp@xxxxxxxxxx>;
> Michael Shych <michaelsh@xxxxxxxxxx>; Wolfram Sang <wsa@xxxxxxxxxx>
> Cc: linux-i2c@xxxxxxxxxxxxxxx; platform-driver-x86@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Subject: [PATCH 1/2] platform/mellanox: NVSW_SN2201 should depend on ACPI
> 
> The only probing method supported by the Nvidia SN2201 platform driver is
> probing through an ACPI match table.  Hence add a dependency on ACPI, to
> prevent asking the user about this driver when configuring a kernel without ACPI
> support.
> 
> Fixes: 662f24826f954d49 ("platform/mellanox: Add support for new SN2201
> system")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Acked-by: Vadim Pasternak <vadimp@xxxxxxxxxx>

> ---
>  drivers/platform/mellanox/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/mellanox/Kconfig b/drivers/platform/mellanox/Kconfig
> index 382793e73a60a8b3..30b50920b278c94b 100644
> --- a/drivers/platform/mellanox/Kconfig
> +++ b/drivers/platform/mellanox/Kconfig
> @@ -80,8 +80,8 @@ config MLXBF_PMC
> 
>  config NVSW_SN2201
>  	tristate "Nvidia SN2201 platform driver support"
> -	depends on HWMON
> -	depends on I2C
> +	depends on HWMON && I2C
> +	depends on ACPI || COMPILE_TEST
>  	select REGMAP_I2C
>  	help
>  	  This driver provides support for the Nvidia SN2201 platform.
> --
> 2.34.1