Re: [PATCH v5 2/3] scsi: hisi_sas: Use DEFINE_SHOW_STORE_ATTRIBUTE helper for debugfs

[Andy Shevchenko]

On Mon, Sep 04, 2023 at 08:48:03AM +0000, Xingui Yang wrote:
> Use DEFINE_SHOW_STORE_ATTRIBUTE helper for read-write file to reduce some

DEFINE_SHOW_STORE_ATTRIBUTE()

> duplicated code.
> 
> Signed-off-by: Luo Jiaxing <luojiaxing@xxxxxxxxxx>
> Signed-off-by: Xingui Yang <yangxingui@xxxxxxxxxx>

Same comments about tags as in previous patch.

Code wise LGTM, FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>


-- 
With Best Regards,
Andy Shevchenko