Re: [PATCH] checkpatch: Avoid warnings for numbered references with URL

From: Joe Perches
Date: Sat Sep 02 2023 - 16:42:59 EST


On Sat, 2023-09-02 at 18:50 +0300, Anton Leontiev wrote:
> Numbered references is one of the most frequently used ways to link
> external resources and them often exeed 75 chars. Add exception for
> these lines.

Conceptually ok, but there are other non-numbered uses of lists like

o link1
o link2
...

or
1: link1
2: link2
...

So maybe this should just allow any long line with a uri/url

>
> Signed-off-by: Anton Leontiev <aleontiev@xxxxxxxxxx>
> ---
> scripts/checkpatch.pl | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 7d16f863edf1..929574f43d4d 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3270,6 +3270,8 @@ sub process {
> # filename then :
> $line =~ /^\s*(?:Fixes:|$link_tags_search|$signature_tags)/i ||
> # A Fixes:, link or signature tag line
> + $line =~ /^\s*\[\d+\]\s+[a-z][\w\.\+\-]*:\/\/\S+/i ||
> + # reference with URL
> $commit_log_possible_stack_dump)) {
> WARN("COMMIT_LOG_LONG_LINE",
> "Prefer a maximum 75 chars per line (possible unwrapped commit description?)\n" . $herecurr);