Re: [PATCH v2] arm64: dts: ipq5018: Correct uart1_pins pinconf

[Sricharan Ramabadhran]

Hi Ziyang,

<...>

> > diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi 
> > b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> > index 9f13d2dcdfd5..91b98020e1c6 100644
> > --- a/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> > @@ -104,10 +104,10 @@ tlmm: pinctrl@1000000 {
> >               #interrupt-cells = <2>;
> >               uart1_pins: uart1-state {
> > -                pins = "gpio31", "gpio32", "gpio33", "gpio34";
> > -                function = "blsp1_uart1";
> > +                pins = "gpio28", "gpio29";
> > +                function = "blsp0_uart1";
> >                   drive-strength = <8>;
> > -                bias-pull-down;
> > +                bias-disabled;
> >               };
> >           };
>
> So this change will have the effect of changing the console on 
> ipq5018-rdp432 from gpio31-gpio34 to gpio28, gpio29.
>
> Have you verified that change on hardware or the schematic ?
>
> https://forum.openwrt.org/t/add-support-for-xiaomi-redmi-ax5400-white-version/140879/22?page=2 
>
>
> This has the wrong UART pinout ?
>
> Is this change something that should be expressed for a particular board ?

 Infact again checked it, the correct pins are "gpio20", "gpio21".
 It works so far because u-boot has configured it.

Regards,
 Sricharan