Re: [PATCH] pinctrl: amd: Don't show `Invalid config param` errors

From: Linus Walleij
Date: Mon Aug 07 2023 - 16:45:20 EST


On Mon, Aug 7, 2023 at 8:17 PM Mario Limonciello
<mario.limonciello@xxxxxxx> wrote:
> On 7/23/2023 14:41, Linus Walleij wrote:
> > On Mon, Jul 17, 2023 at 10:17 PM Mario Limonciello
> > <mario.limonciello@xxxxxxx> wrote:
> >
> >> On some systems amd_pinconf_set() is called with parameters
> >> 0x8 (PIN_CONFIG_DRIVE_PUSH_PULL) or 0x14 (PIN_CONFIG_PERSIST_STATE)
> >> which are not supported by pinctrl-amd.
> >>
> >> Don't show an err message when called with an invalid parameter,
> >> downgrade this to debug instead.
> >>
> >> Cc: stable@xxxxxxxxxxxxxxx # 6.1
> >> Fixes: 635a750d958e1 ("pinctrl: amd: Use amd_pinconf_set() for all config options")
> >> Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>
> >
> > Applied for nonurgent fixes.
> >
>
> Just wanted to check if you'll be sending this out for -rc6. It
> backported to stable and a few bugs cropped up because it's noisy.

No, nonurgent means I queue it for v6.6. Fear of causing regressions
on mainline is the reason to not send fixes unless they are urgent.

Yours,
Linus Walleij