Re: [PATCH 1/3] dt-bindings: display: panel: add startek kd070fhfid015 support

[Alexandre Mergnat]

Hi Krzysztof,

Thanks for your review

On 12/07/2023 07:32, Krzysztof Kozlowski wrote:
> On 11/07/2023 17:36, Alexandre Mergnat wrote:
> > The Startek KD070FHFID015 is a 7-inch TFT LCD display with a resolution

snip

> > +
> > +  dcdc-gpios: true
>
>  From where does this come? Which schema defines it?

It's a miss. I will fix it and reset-gpios too by adding a maxItems and 
a description.

> > +
> > +  height-mm:
> > +    const: 151
> > +
> > +  iovcc-supply:
> > +    description: Reference to the regulator powering the panel IO pins.
> > +
> > +  reg:
> > +    maxItems: 1
> > +    description: DSI virtual channel
> > +
> > +  reset-gpios: true
> > +
> > +  port: true
> > +
> > +  power-supply: true
> > +
> > +  width-mm:
> > +    const: 95
> > +
> > +additionalProperties: false
> > +
> > +required:
> > +  - compatible
> > +  - dcdc-gpios
> > +  - iovcc-supply
> > +  - reg
> > +  - reset-gpios
> > +  - port
> > +  - power-supply
>
> Missing example.

I will add it.

--
Regards,
Alexandre