RE: [PATCH] drm/hyperv: Fix a compilation issue because of not including screen_info.h
From: Michael Kelley (LINUX)
Date: Mon Jul 10 2023 - 01:22:41 EST
From: Sui Jingfeng <suijingfeng@xxxxxxxxxxx> Sent: Sunday, July 9, 2023 3:05 AM
>
> drivers/video/fbdev/hyperv_fb.c: In function 'hvfb_getmem':
> >> drivers/video/fbdev/hyperv_fb.c:1033:24: error: 'screen_info' undeclared (first use
> in this function)
> 1033 | base = screen_info.lfb_base;
> | ^~~~~~~~~~~
> drivers/video/fbdev/hyperv_fb.c:1033:24: note: each undeclared identifier is reported
> only once for each function it appears in
> --
> drivers/gpu/drm/hyperv/hyperv_drm_drv.c: In function 'hyperv_setup_vram':
> >> drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: error: 'screen_info' undeclared
> (first use in this function)
> 75 | drm_aperture_remove_conflicting_framebuffers(screen_info.lfb_base,
> | ^~~~~~~~~~~
> drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: note: each undeclared identifier is
> reported only once for each function it appears in
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202307090823.nxnT8Kk5-lkp@xxxxxxxxx/
> Fixes: 81d2393485f0 ("fbdev/hyperv-fb: Do not set struct fb_info.apertures")
> Fixes: 8b0d13545b09 ("efi: Do not include <linux/screen_info.h> from EFI header")
> Signed-off-by: Sui Jingfeng <suijingfeng@xxxxxxxxxxx>
> ---
> drivers/gpu/drm/hyperv/hyperv_drm_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
> b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
> index a7d2c92d6c6a..8026118c6e03 100644
> --- a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
> +++ b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
> @@ -7,6 +7,7 @@
> #include <linux/hyperv.h>
> #include <linux/module.h>
> #include <linux/pci.h>
> +#include <linux/screen_info.h>
>
> #include <drm/drm_aperture.h>
> #include <drm/drm_atomic_helper.h>
> --
> 2.25.1
Reviewed-by: Michael Kelley <mikelley@xxxxxxxxxxxxx>