Re: [RFC PATCH v4 0/6] (mostly) Arch-independent livepatch

From: Petr Mladek
Date: Tue Feb 09 2016 - 10:56:38 EST


On Wed 2016-02-03 20:11:05, Jessica Yu wrote:
> This patchset removes livepatch's need for architecture-specific relocation
> code by leveraging existing code in the module loader to perform
> arch-dependent work. Specifically, instead of duplicating code and
> re-implementing what the apply_relocate_add() function in the module loader
> already does in livepatch's klp_write_module_reloc(), we reuse
> apply_relocate_add() to write relocations. The hope is that this will make
> livepatch more easily portable to other architectures and greatly reduce
> the amount of arch-specific code required to port livepatch to a particular
> architecture.
>
> Jessica Yu (6):
> Elf: add livepatch-specific Elf constants
> module: s390: keep mod_arch_specific for livepatch modules
> samples: livepatch: mark as livepatch module
> Documentation: livepatch: outline Elf format and requirements for
> patch modules

For the four above patches:

Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>


> module: preserve Elf information for livepatch modules
> livepatch: reuse module loader code to write relocations

These two still need some tweaking.

I think that we are getting close. I like the way we go.
The documentation is excellent.

Thanks a lot for working on it.

Best Regards,
Petr