Re: [PATCH 0/4] CPUFreq stats: Bug fixes

From: Rafael J. Wysocki
Date: Mon Jan 06 2014 - 15:48:52 EST


On Thursday, September 26, 2013 03:59:50 PM Viresh Kumar wrote:
> Hi Rafael,
>
> I know you asked me not to send any more patches before the earlier ones get
> into kernel. I got to this as Nicolas Pitre required to send few CPUFreq patches
> for ARM's big LITTLE In-Kernel-Switcher. And within linaro we have hacked these
> bugs in a bad way..
>
> Because of his dependency I am forced to send these.. These aren't introduced
> recently and so they can be included in 3.13.
>
> There are several problems/bugs in cpufreq-stats specially with cpufreq drivers
> as modules and suspend/resume path. These are mentioned well in changelogs.
>
> These are tested over my thinkpad (acpi-cpufreq) in following way:
> [1] offline+online all CPUs except boot cpu in a while loop
> [2] then do suspend resume
> [3] repeat [1] and [2] several times.
>
> No issues found..
>
> Also tested on my exynos board:
> - Added cpufreq_unregister/register while loop in exynos-cpufreq.c so that we
> continuously register/unregister driver... Stats were working fine now..
> - Compile cpufreq-stats as module and insert/remove it several times after
> removing above hack (as that doesn't let linux boot :) )..
>
> @Srivatsa: You also have fairly good idea of cpufreq now, so please give some
> time to review this :)
>
> @Nico: Can you remove the hacky code from IKS tree and test these instead to see
> if we still have any issues?

Can you please rebase this series on top of linux-pm.git/bleeding-edge and
resend it? Chances are it might make it into 3.14.

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/