Re: [PATCH 0/4] x86: Add Cache QoS Monitoring (CQM) support

[Waskiewicz Jr, Peter P]

On Mon, 2014-01-06 at 18:53 +0100, Peter Zijlstra wrote:
> On Mon, Jan 06, 2014 at 04:47:57PM +0000, Waskiewicz Jr, Peter P wrote:
> > > Yeah that's not accurate, nor desired I think, because you get into
> > > horrible problems with hierarchies, do child groups belong to your RMID
> > > or not?
> > 
> > I'd rather not support a child group of a child group.  Only groups off
> > the root, and each group would be assigned an RMID when it's activated
> > for monitoring.
> 
> Yeah, that's a complete non started for cgroups. Cgroups need to be
> completely hierarchical.
> 
> So even the root group should represent all tasks; which if you fragment
> RMIDs on child cgroups doesn't work anymore.

The root group does represent all tasks in the current patchset on RMID
0.  Then any child assigned to another group will be assigned to a
different RMID.  It looks like this:

                       root (rmid 0)
                       /  \
             (rmid 4) g1  g2 (rmid 16)

We could keep going down from there, but I don't see it buying anything
extra.

Cheers,
-PJ

-- 
PJ Waskiewicz				Open Source Technology Center
peter.p.waskiewicz.jr@xxxxxxxxx		Intel Corp.
N‹§²æìr¸›yúèšØb²X¬¶ÇvØ^–)Þ{.nÇ+‰·¥Š{±‘êçzX§¶›¡Ü}©ž²ÆzÚ&j:+v‰¨¾«‘êçzZ+€Ê+zf£¢·hšˆ§~†­†Ûiÿûàz¹®w¥¢¸?™¨è­Ú&¢)ßf”ù^jÇy§m…á@A«a¶Úÿ0¶ìh®å’i