Re: [RFC] mm: show message when updating min_free_kbytes in thp

From: Han Pingtian
Date: Sat Jan 04 2014 - 19:35:50 EST


On Fri, Jan 03, 2014 at 10:17:54AM -0800, Dave Hansen wrote:
> On 01/02/2014 07:33 PM, Han Pingtian wrote:
> > @@ -130,8 +130,11 @@ static int set_recommended_min_free_kbytes(void)
> > (unsigned long) nr_free_buffer_pages() / 20);
> > recommended_min <<= (PAGE_SHIFT-10);
> >
> > - if (recommended_min > min_free_kbytes)
> > + if (recommended_min > min_free_kbytes) {
> > + pr_info("raising min_free_kbytes from %d to %d to help transparent hugepage allocations\n",
> > + min_free_kbytes, recommended_min);
> > min_free_kbytes = recommended_min;
> > + }
> > setup_per_zone_wmarks();
> > return 0;
> > }
>
> I know I gave you that big bloated string, but 108 columns is a _wee_
> bit over 80. :)
>
> Otherwise, I do like the new message

Thanks. This is the new version: