Re: [PATCH resend] scripts: Coccinelle script for pm_runtime_*return checks with IS_ERR_VALUE

From: Michal Marek
Date: Fri Jan 03 2014 - 08:40:18 EST


On Fri, Jan 03, 2014 at 02:29:35PM +0100, Julia Lawall wrote:
>
> On Fri, 3 Jan 2014, Michal Marek wrote:
>
> > On 2013-12-02 14:39, Nishanth Menon wrote:
> > > As indicated by Sekhar in [1], there seems to be a tendency to use
> > > IS_ERR_VALUE to check the error result for pm_runtime_* functions which
> > > make no sense considering commit c48cd65 (ARM: OMAP: use consistent
> > > error checking) - the error values can either be < 0 for error OR
> > > 0, 1 in cases where we have success.
> > >
> > > So, setup a coccinelle script to help identify the same.
> >
> > Julia, Gilles, do you have any objections to this semantic patch?
>
> No objections.
>
> Acked-by: Julia Lawall <julia.lawall@xxxxxxx>

Thanks, applied to kbuild.git#misc.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/