Re: [RFC PATCH net-next 1/4] net: introduce backup_classid to structskbuff

From: John Fastabend
Date: Fri Jan 03 2014 - 01:22:15 EST


On 01/02/2014 09:34 PM, David Miller wrote:
From: Libo Chen <clbchenlibo.chen@xxxxxxxxxx>
Date: Fri, 3 Jan 2014 11:11:04 +0800


introduce backup_classid to struct skbuff,
we can use it to backup sk_classid when net_ns switch.

Signed-off-by: Libo Chen <clbchenlibo.chen@xxxxxxxxxx>

Sorry, no new sk_buff members unless there is absolutely not other
possible implementation.

sk_buff is too big as-is.

To get what you want fix the dev_forward_skb() call. But its
not clear to me why you would expect the sock info to be propagated
like this. It seems like an incorrect assumption or a misunderstanding
somewhere. If the virtual link was a physical link you wouldn't expect
to know anything about the senders socket.

Thanks,
John

--
John Fastabend Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/