Re: [PATCH] lib/vsprintf: add %pT[C012] format specifier

[Pavel Machek]

Hi!

> > > > #define PRINTK_PID      "\002"
> > > > #define PRINTK_TASK_ID  "\003"  /* "comm:pid" */
> > > >
> > > >         printk(PRINTK_TASK_ID ": hair on fire\n");
> > > >
> > > > It's certainly compact.  I doubt if there's any existing code which
> > > > deliberately prints control chars?
> > > 
> > > But the rest looks OK to me.
> > 
> > Tell me again, what's wrong with using p or current?
> > 
> > printk("%pt", current);
> 
> Nothing much.  It's just that all these callsites are generating the
> code to pass an argument which the callee already has access to. 
> Optimizing that will reduce text size a bit.

Can we do "printk("%pt", 0)", then? Or just pass current and live with
few bytes of penalty. There are probably less ugly ways to make kernel
smaller. Inventing another escape character for printk is extremely
ugly.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/