Re: [PATCH v2 5/7] sysfs: add support for binary attributes in groups

From: Greg Kroah-Hartman
Date: Thu Jul 11 2013 - 12:59:28 EST


On Thu, Jul 11, 2013 at 01:45:53PM +0200, Oliver Schinagl wrote:
> On 11-07-13 02:36, Greg Kroah-Hartman wrote:
> >groups should be able to support binary attributes, just like it
> >supports "normal" attributes. This lets us only handle one type of
> >structure, groups, throughout the driver core and subsystems, making
> >binary attributes a "full fledged" part of the driver model, and not
> >something just "tacked on".
> However when only using binary attributes it warns and doesn't
> create anything. The attached patch fixes that.

Ah, missed that, I didn't have a binary-only attribute group to test
that out, thanks.

> >Reported-by: Oliver Schinagl <oliver+list@xxxxxxxxxxx>
> If I may be so bold and ask to change my e-mail address to
> <oliver@xxxxxxxxxxx> that would be kind. I use the +list delimiter
> to put all the mailing list mails in a separate mailbox.

Sure, no problem at all, will do so. And I'll queue up your attached
patch as well, it looks great.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/