Re: [PATCH 3/4] mfd: s2mps11: Add device tree support
From: Mark Brown
Date: Wed Jul 03 2013 - 14:05:21 EST
On Mon, Jun 24, 2013 at 04:50:57PM +0530, Yadwinder Singh Brar wrote:
> + regulator-ramp-delay for BUCKs = [6250/12500/25000(default)/50000] uV/us
> + Optional property for BUCK[2/3/4/6] only:
> + regulator-ramp-disable: boolean, disables ramp delay on hardware.
If these were device specific bindings they ought to be namespaced as
samsung, or similar. However I think they are generic enough that they
could just be added to the standard regulator bindings, ramp rates are
common enough and units of time are a simple way to express them. I'd
also suggest just using a ramp delay of zero for no ramp, it's simpler
and will probably fall naturally out of the bindings.
Please just send a separate patch adding these to the generic regulator
binding document instead of this one, we can add generic code/ops for
this later.
Attachment:
signature.asc
Description: Digital signature