Re: [PATCH 0/2] ext4: deadlocks after allocation failure inext4_init_io_end()

From: Zheng Liu
Date: Tue May 14 2013 - 02:48:49 EST


On Mon, May 13, 2013 at 11:08:11PM +0400, Alexey Khoroshilov wrote:
> Hi, Ted!
>
> Our tests for ext4 with targeted fault injection were stalled in Uninterruptible Sleep State
> when they simulate a memory allocation failure in ext4_init_io_end() while it is called from
> mpage_da_submit_io() or ext4_writepage().
>
> It looks like the problems are that pages left locked after failure handling.
>
> I am not completely sure that my patches take into account all required aspects,
> but the tests are passed if the patches are applied.
>
> Please find below syslog excerpt for the first issue.
>
> Found by Linux File System Verification project (linuxtesting.org/spruce).

Hi Alexey,

Thanks for fixing this. The patch series looks good to me. But the
commit (ext4: use io_end for multiple bios) has been reverted in dev
branch of ext4 tree. I forward the mail to Jan to let him know your
fixes.

Regards,
- Zheng
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/