Re: [RFC -next] linux/linkage.h: fix symbol prefix handling
From: Stephen Rothwell
Date: Mon Mar 11 2013 - 08:08:02 EST
Hi Rusty,
On Mon, 11 Mar 2013 17:05:17 +1030 Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:
>
> diff --git a/arch/blackfin/Kconfig b/arch/blackfin/Kconfig
> index 600494c..cd0f7c7 100644
> --- a/arch/blackfin/Kconfig
> +++ b/arch/blackfin/Kconfig
> @@ -1,6 +1,5 @@
> -config SYMBOL_PREFIX
> - string
> - default "_"
> +config SYMBOL_PREFIX_UNDERSCORE
> + def_bool y
Please, if you are going to do this, just have
config SYMBOL_PREFIX_UNDERSCORE
bool
in one Kconfig file (probably arch/Kconfig) and then select it from the
appropriate architecture Kconfig files. You could even put a help text
on it to explain why a new architecture may need to select it.
--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx
Attachment:
pgp00000.pgp
Description: PGP signature