[PATCH 03/05] irqchip: intc-irqpin: Add force comments

From: Magnus Damm
Date: Tue Feb 26 2013 - 06:53:32 EST


From: Magnus Damm <damm@xxxxxxxxxxxxx>

Add comments to describe the special case for
"force" versions of enable and disable functions.

Signed-off-by: Magnus Damm <damm@xxxxxxxxxxxxx>
---

Thanks to Thomas Gleixner for this suggestion.

drivers/irqchip/irq-renesas-intc-irqpin.c | 9 +++++++++
1 file changed, 9 insertions(+)

--- 0006/drivers/irqchip/irq-renesas-intc-irqpin.c
+++ work/drivers/irqchip/irq-renesas-intc-irqpin.c 2013-02-26 19:36:33.000000000 +0900
@@ -199,6 +199,11 @@ static void intc_irqpin_irq_enable_force
int irq = p->irq[irqd_to_hwirq(d)].requested_irq;

intc_irqpin_irq_enable(d);
+
+ /* enable interrupt through parent interrupt controller,
+ * assumes non-shared interrupt with 1:1 mapping
+ * needed for busted IRQs on some SoCs like sh73a0
+ */
irq_get_chip(irq)->irq_unmask(irq_get_irq_data(irq));
}

@@ -207,6 +212,10 @@ static void intc_irqpin_irq_disable_forc
struct intc_irqpin_priv *p = irq_data_get_irq_chip_data(d);
int irq = p->irq[irqd_to_hwirq(d)].requested_irq;

+ /* disable interrupt through parent interrupt controller,
+ * assumes non-shared interrupt with 1:1 mapping
+ * needed for busted IRQs on some SoCs like sh73a0
+ */
irq_get_chip(irq)->irq_mask(irq_get_irq_data(irq));
intc_irqpin_irq_disable(d);
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/