Re: [PATCH] perf report: fix handling of memory sampling sort orders

From: Namhyung Kim
Date: Tue Feb 26 2013 - 00:46:23 EST


Hi,

On Fri, 22 Feb 2013 15:43:22 -0300, Arnaldo Carvalho de Melo wrote:
> Em Fri, Feb 22, 2013 at 03:28:38PM +0100, Stephane Eranian escreveu:
>>
>> When the memory sampling sort orders were used on perf.data
>> files without memory sampling data, it would crash perf. This
>> patch fixes this by handling the lack of memory information
>> gracefully, printing N/A and formatting columns correctly
>> whenever necessary.

It'd be great if we could detect the perf.data contains memory sampling
data and then warn user about it and exit like I did for branch
sampling. What do you think?

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/