Re: [PATCH v3] char/tpm: Use true and false for bools

[Kent Yoder]

On Thu, Nov 29, 2012 at 01:54:52PM -0800, Joe Perches wrote:
> On Thu, 2012-11-29 at 22:08 +0100, Peter Huewe wrote:
> > Bool initializations should use true and false.  Bool tests don't need
> > comparisons
> []
> > .v3 for this tiny patch... shame on me.
> 
> Don't be silly...
> 
> > diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
> []
> > @@ -545,7 +545,7 @@ static int tpm_tis_init(struct device *dev, resource_size_t start,
> >  			rc = -ENODEV;
> >  			goto out_err;
> >  		}
> > -		itpm = (probe == 0) ? 0 : 1;
> > +		itpm = !!probe;
> 
> Even more trivia:
> 
> This !! isn't necessary as ints assigned to bool are converted
> by the compiler to 0 or 1.

  Good to know, thanks Joe!

Kent

> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/