Re: [RFC PATCH 3/3] USB: forbid memory allocation with I/O during bus reset if storage interface exits

From: Oliver Neukum
Date: Mon Oct 15 2012 - 08:32:54 EST


On Monday 15 October 2012 20:06:36 Ming Lei wrote:
> On Mon, Oct 15, 2012 at 5:34 PM, Oliver Neukum <oneukum@xxxxxxx> wrote:
> >
> > I think limiting this to devices which have a storage device is not
> > productive. What if you are using iSCSI or nbd? In the long run
>
> You mean other non-mass storage or non-uas usb interfaces may
> be involved in iSCSI or nbd? If not, the patch should be OK.
> If yes, could you list them?

All network devices?

> > we will see busses attached to busses and as soon as the daughter
> > bus is hotpluggable you are thwarted anyway. Just do it unconditionally.
>
> IMO, doing it unconditionally is not good because big chunk buffer
> is often allocated in probe() path.

It would be a chunk that has just been freed.

Regards
Oliver

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/