Hardcoded instruction causes certain features to fail on ARMplatfrom due to endianness

From: Yangfei (Felix)
Date: Sun Oct 14 2012 - 23:46:57 EST


Hi all,

I found that hardcoded instruction in inline asm can cause certains certain features fail to work on ARM platform due to endianness.
As an example, consider the following code snippet of platform_do_lowpower function from arch/arm/mach-realview/hotplug.c:
/ *
* here's the WFI
*/
asm(".word 0xe320f003\n"
:
:
: "memory", "cc");

The instruction generated from this inline asm will not work on big-endian ARM platform, such as ARM BE-8 format. Instead, an exception will be generated.

Here the code should be:
/ *
* here's the WFI
*/
asm("WFI\n"
:
:
: "memory", "cc");

Seems the kernel doesn't support ARM BE-8 well. I don't know why this problem happens.
Can anyone tell me who owns this part? I can prepare a patch then.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/