Re: Spurious warning in checkpatch.pl?

[Larry Finger]

On 10/12/2012 01:38 PM, Joe Perches wrote:
> On Fri, 2012-10-12 at 13:23 -0500, Larry Finger wrote:
> > Andy,
> >
> > The checkpatch.pl version in mainline is issuing what I think are false warnings
> > of the type
> >
> > WARNING: networking block comments put the trailing */ on a separate line
> > #93: FILE: drivers/net/wireless/rtlwifi/wifi.h:208:
> > +       u32 rf_rb;              /* rflssi_readback */
> >
> > Is a trailing comment for the member of a struct not allowed?
>
> It's allowed.  Maybe even better, encouraged.
>
> It's a change I made in commit 058806007450
> ("checkpatch: check networking specific block comment style")
> without sufficient testing.
>
> I'll see about fixing it.

Joe,

Good. I will ignore those warnings.

One more question. Was the warning below intended?

WARNING: networking block comments put the trailing */ on a separate line
#1846: FILE: drivers/net/wireless/rtlwifi/rtl8723ae/hal_btc.h:27:
+ *****************************************************************************/

To me, that line at the end of a copyright block looks better then


 ****************************************************************************
 */

Larry



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/