RE: [PATCH] genirq: for edge interrupt IRQS_ONESHOT support withirq thread

[Liu, Chuansheng]

> -----Original Message-----
> From: Thomas Gleixner [mailto:tglx@xxxxxxxxxxxxx]
> Sent: Friday, October 12, 2012 8:32 PM
> To: Liu, Chuansheng
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] genirq: for edge interrupt IRQS_ONESHOT support with irq
> thread
> 
> On Fri, 12 Oct 2012, Chuansheng Liu wrote:
> >
> > In our system, there is one edge interrupt, and we want it to be
> > irq thread with IRQS_ONESHOT, and found in handle_edge_irq(),
> > even with IRQS_ONESHOT, the irq is still unmasked without care of
> > flag IRQS_ONESHOT.
> >
> > It causes IRQS_ONESHOT can not work well for edge interrupt, but also
> > after the irq thread finished with flag IRQS_ONESHOT, the irq will be
> > possible to be unmasked again, it should be messing mask/unmask logic.
> 
> This is just wrong. By masking edge interrupts you will run into
> situations where you will lose interrupts.
> 
> Can you please explain, why you want to mask your edge interrupt?
When I request_irq with irq thread handler and flag IRQS_ONESHOT, if do not mask the edge interrupt,
the primary handler and irq thread maybe run at the same time, and in my real case it causes spin deadlock.

You means it is not right with IRQS_ONESHOT for edge interrupt?
> 
> Thanks,
> 
> 	tglx
> 
> 
> > Signed-off-by: liu chuansheng <chuansheng.liu@xxxxxxxxx>
> > ---
> >  kernel/irq/chip.c |    8 +++++++-
> >  1 files changed, 7 insertions(+), 1 deletions(-)
> >
> > diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
> > index 57d86d0..f23f524 100644
> > --- a/kernel/irq/chip.c
> > +++ b/kernel/irq/chip.c
> > @@ -497,7 +497,13 @@ handle_edge_irq(unsigned int irq, struct irq_desc
> *desc)
> >  	kstat_incr_irqs_this_cpu(irq, desc);
> >
> >  	/* Start handling the irq */
> > -	desc->irq_data.chip->irq_ack(&desc->irq_data);
> > +	if (desc->istate & IRQS_ONESHOT) {
> > +		mask_ack_irq(desc);
> > +		handle_irq_event(desc);
> > +		cond_unmask_irq(desc);
> > +		goto out_unlock;
> > +	} else
> > +		desc->irq_data.chip->irq_ack(&desc->irq_data);
> >
> >  	do {
> >  		if (unlikely(!desc->action)) {
> > --
> > 1.7.0.4
> >
> >
> >
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/