Re: [PATCH 1/3] Coccicheck: Add the rep+ctxt mode

From: Michal Marek
Date: Thu Oct 11 2012 - 16:15:02 EST


Dne 11.10.2012 15:46, Nicolas Palix napsal(a):
> Hi,
>
> On Thu, Oct 11, 2012 at 3:34 PM, Michal Marek <mmarek@xxxxxxx> wrote:
>> On Thu, Sep 20, 2012 at 10:30:46PM +0200, Nicolas Palix wrote:
>>> This adds a 'rep+ctxt' mode which prints the warning
>>> message followed by the context.
>>>
>>> Signed-off-by: Nicolas Palix <nicolas.palix@xxxxxxx>
>>> ---
>>> scripts/coccicheck | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>> diff --git a/scripts/coccicheck b/scripts/coccicheck
>>> index 823e972..eb43e40 100755
>>> --- a/scripts/coccicheck
>>> +++ b/scripts/coccicheck
>>> @@ -95,6 +95,9 @@ coccinelle () {
>>> $SPATCH -D report $FLAGS -sp_file $COCCI $OPT $OPTIONS -no_show_diff || \
>>> $SPATCH -D context $FLAGS -sp_file $COCCI $OPT $OPTIONS || \
>>> $SPATCH -D org $FLAGS -sp_file $COCCI $OPT $OPTIONS
>>> -no_show_diff || exit 1
>>
>> Your mailer broke this line into two, please try to avoid this next
>> time. Also, please CC lkml when submitting patches. I applied the patch
>> to kbuild.git#misc now.
>
> Ooops.. Sorry. I didn't notice.
>
> The patches are publish on github in my coccicheck branch.
> https://github.com/npalix/linux/commits/coccicheck
>
> Do you prefer a pull request next time to avoid such things ?

Yes, if you base the branch on some tagged release, preferably the
latest -rc1.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/