Re: [PATCH] coredump: always kill the task no matter what

From: Jerome Glisse
Date: Thu Oct 11 2012 - 16:04:20 EST


On Thu, Oct 11, 2012 at 3:07 PM, <j.glisse@xxxxxxxxx> wrote:
> From: Jerome Glisse <jglisse@xxxxxxxxxx>
>
> If do_coredump fails for any reason make sure that the task
> is actualy wakeup and properly kill otherwise we endup with
> zombies task.
>
> Signed-off-by: Jerome Glisse <jglisse@xxxxxxxxxx>
> ---
> fs/coredump.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/coredump.c b/fs/coredump.c
> index fd37fac..4b61468 100644
> --- a/fs/coredump.c
> +++ b/fs/coredump.c
> @@ -643,11 +643,11 @@ fail_dropcount:
> fail_unlock:
> kfree(cn.corename);
> fail_corename:
> - coredump_finish(mm);
> revert_creds(old_cred);
> fail_creds:
> put_cred(cred);
> fail:
> + coredump_finish(mm);
> return;
> }
>
> --
> 1.7.12.1
>

Actually wrong patch, this one does not solve my issue.

Cheers,
Jerome
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/