Re: [PATCH 1/2] scatterlist: add sg_nents

From: Geert Uytterhoeven
Date: Thu Oct 11 2012 - 06:28:52 EST


On Thu, Oct 11, 2012 at 12:27 PM, Geert Uytterhoeven
<geert@xxxxxxxxxxxxxx> wrote:
> On Wed, Sep 26, 2012 at 11:49 AM, Maxim Levitsky
> <maximlevitsky@xxxxxxxxx> wrote:
>> +int sg_nents(struct scatterlist *sg)
>
> unsigned int?

and "const struct scatterlist *sg"? Ah no, that won't work as
sg_next() treats non-const pointers :-(

>> +{
>> + int nents = 0;
>> + while (sg) {
>> + nents++;
>> + sg = sg_next(sg);
>> + }
>> +
>> + return nents;
>> +}

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/